122 replies to this topic

[ericjung]

I didn't work, teo. First I deleted the section you mentioned, but the windows are still to small.
I even put the values of that same section from the test profile which worked OK in this one, but that didn't work even. Any more suggestions?

width and height are now stored in passwordmaker.rdf, not localstore.rdf.

[Alf]

width and height are now stored in passwordmaker.rdf, not localstore.rdf.

I can't find any entry in this file that has some kind of height/width parameters in it.
Can you point out what string is used?

[ericjung]

I can't find any entry in this file that has some kind of height/width parameters in it.
Can you point out what string is used?

Look for <RDF:Description RDF:about="http://passwordmaker.mozdev.org/globalSettings"
...
...
NSx:height="421"
NSx:width="758"


where x is a number. You might not have these values if you haven't switched between Basic and Advanced mode.... and that might be a bug that's causing the sizing problems for you. Let me know, please!

[Alf]

Look for <RDF:Description RDF:about="http://passwordmaker.mozdev.org/globalSettings"
...
...
NSx:height="421"
NSx:width="758"


where x is a number. You might not have these values if you haven't switched between Basic and Advanced mode.... and that might be a bug that's causing the sizing problems for you. Let me know, please!

You were right, there were no height/width value in that file. Switched from Advanced to Basic and back and then they appears in the file. But those are the heigth/width of the main window. And the problem is with the other windows, see my screen shots some post above:
http://www.babelzilla.org/forum/index.php?...ost&p=32661

[Goofy]

No, I will adapt the extension to the WTS process. Please tell me the offending files and characters. I will change them and upload a new XPi.

Thanks,
grimholtz

Ah you know perfectly there is nothing offending in your files and characters
And keep in mind I am no coder, please.

What I thought to do is
- remove all special characters (example of diacritic and all that) from the dtd file since they need absoltulety not to be translated
- logically all the special chars are to be left in the tips.xul file

So here is the part of tips.xul I changed (bottom of file)
http://pastebin.mozilla.org/190092

And this is what it gives at the end of the en-US/passwdmaker.dtd
http://pastebin.mozilla.org/190093

I have tested this OK with en-US and fr-FR (not available for other locales)
I am pretty sure it will not cause problems with the WTS

Just try >>>  passwdmaker_1.7b4.xpi   232.68KB   1 downloads

[ericjung]

You were right, there were no height/width value in that file. Switched from Advanced to Basic and back and then they appears in the file. But those are the heigth/width of the main window. And the problem is with the other windows, see my screen shots some post above:
http://www.babelzilla.org/forum/index.php?...ost&p=32661

Thanks, Alf! I've fixed those two bugs now and they will be in the next release.

What I thought to do is
- remove all special characters (example of diacritic and all that) from the dtd file since they need absoltulety not to be translated biggrin.gif
- logically all the special chars are to be left in the tips.xul file

Thank you, Goofy. I will either use your solution or completely remove these characters.

[ericjung]

PasswordMaker 1.7beta5 uploaded with Goofy's suggested changes

Unfortunately, I forgot to update the non-en-US locales in the XPI before uploading. This means all your hard work between 1.7beta4 and now is gone!.

I sincerely apologize and beg your forgiveness.

[Goofy]

PasswordMaker 1.7beta5 uploaded with Goofy's suggested changes

Unfortunately, I forgot to update the non-en-US locales in the XPI before uploading. This means all your hard work between 1.7beta4 and now is gone!.

I sincerely apologize and beg your forgiveness.

Welcome in the GoofyMistake ™ contest!

Important GoofyNotes for translators:

1. Do NOT trust the wts string counter, there can be new strings to translate even though the progressmeter is proudly displaying 116% done (due to old strings not removed)

2. Be very careful with this non-yellow line in passwdmaker.dtd (as already mentioned by Alf and teo)

What is displayed :

Code

opts.035.tooltiptext
&opts.034a.tooltiptext;
&opts.034.tooltiptext;

What you should write instead

opts.035.tooltiptext
&opts.034a.tooltiptext;
&opts.034a.tooltiptext;

If you miss the little "a" your extension will break!

[Alf]

Dutch (nl-NL) translation v. 1.7b5 updated, tested and set as released, with the following remarks:

- Original width of the option windows as described before is still to small, but the good thing is that after changing the width is remembered.
- This is not the case with the height of the Tips window (see screenshot in my previous post). It's still to small and changes aren't remembered. For the Dutch translation the height of this window should be 385 px.
- There is a string "New account" in some windows, that should be made translatable as well. Such entity is present in the file already, used in a drop-down box.
- There is a drop-down box with the following values: text, textarea, password, checkbox, select, radio. These items should be made translatable as well.
- A lot of tooltips are to small for presenting the complete translated text. Made them auto-adjust to its content.

[Goofy]

@grimholz

I have tested a very simple thing with xul dialog window sizes: make them localizable, so that every translator adjust to the needs of each language.

Here in tips.xul I added height and width :

Code

<?xml-stylesheet href="chrome://global/skin/global.css" type="text/css"?>
<!DOCTYPE window SYSTEM "chrome://passwdmaker/locale/passwdmaker.dtd">

<dialog windowtype="passwordmaker" id="passwordmakeraccountsettings"
                xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
                xmlns:html="http://www.w3.org/1999/xhtml"
                title="&tips.window.title;"
                width="&tips.window.width;"
                height="&tips.window.height;"

and added the relative entities with a value in the en-US, fr-FR and nl-NL dtd files (not available for other locales)

Please alf test (I chose big values for you )

Attached Files

•  passwdmaker_goofy_resize_1.7b5.xpi   228.91KB   0 downloads

[teo]

@Goofy,
Issue with tips window size is only Alf problem (read Alf answer on mine post). This window going to height automatically. Please add to line 'tips.017b.innerHTML' any characters you want and window will be going to content. Test it.

Do you have any problems with windows sizes?

[teo]

- Original width of the option windows as described before is still to small, but the good thing is that after changing the width is remembered.

Alf, please try abbreviate these phrases: 'Status van geselecteerde account' and 'Niet op schijf opgeslagen' from passwdmaker.properties file.

[ericjung]

Welcome in the GoofyMistake ™ contest!

Important GoofyNotes for translators:

1. Do NOT trust the wts string counter, there can be new strings to translate even though the progressmeter is proudly displaying 116% done (due to old strings not removed)

2. Be very careful with this non-yellow line in passwdmaker.dtd (as already mentioned by Alf and teo)

What is displayed :

CODE

opts.035.tooltiptext
&opts.034a.tooltiptext;
&opts.034.tooltiptext;

What you should write instead
If you miss the little "a" your extension will break!

Does this need to be fixed in en-US?

[Goofy]

Does this need to be fixed in en-US?

No the en-US as submitted is OK, but translators may have missed the very tiny change

[ericjung]

Hi Eric,
I found problem with display 'Close" button when I checked "I use more than one master password' option ...all code options.xul file from line 227 to 588 should be inside <vbox flex="1"></vbox>

Teo, is this still necessary with 1.7beta5? I don't think it is because I changed the "I use more than one master password" so there is no hidden/collapse section anymore. Can you try to reproduce the problem without extra <vbox> please? I would try but I never saw the original problem, so I'm not the best person to test it.

[ericjung]

1.7 beta 6 released with some very small changes to passwdmaker.dtd and passwdmaker.properties. Notably, fglobalsettings.onHideMPWField.01 has been changed to globalsettings.onHideMPWField.02 because of a typo in the key (fglobalsettings.onHideMPWField.01). Once again, I'm hoping this is the FINAL beta for 1.7.

WELCOME, GERMANGUY!! WE'RE EAGERLY ANTICIPATING de-DE !!!

[teo]

Teo, is this still necessary with 1.7beta5? I don't think it is because I changed the "I use more than one master password" so there is no hidden/collapse section anymore. Can you try to reproduce the problem without extra <vbox> please? I would try but I never saw the original problem, so I'm not the best person to test it.

In the 1.7beta5 is no necessary.

[Alf]

Dutch (nl-NL) translation v. 1.7b6 updated, tested and set as released, with the following remarks:

- This is not the case with the height of the Tips window (see screenshot in my previous post). It's still to small and changes aren't remembered. For the Dutch translation the height of this window should be 385 px.

This is working OK now, window remembers it changed size. Thanks for the fix.

- There is a string "New account" in some windows, that should be made translatable as well. Such entity is present in the file already, used in a drop-down box.
- There is a drop-down box with the following values: text, textarea, password, checkbox, select, radio. These items should be made translatable as well.
- A lot of tooltips are to small for presenting the complete translated text. Made them auto-adjust to its content.

These remarks are still valid. Any news on this?

Now there is still 1 window that doesn't remembers its size: Basic options. See attachment.
If I change the size of the basic window and close and reopen it, size is OK still. But if I switch to Advanced options and back to Basic, the size is reset to its original value.

Please alf test

Goofy, I didn't test it because there was another update of the extension.

(I chose big values for you )

LOL As a Frenchman you should probably we aware that European languages mostly needs more room for text items then the original English ones., especially for Dutch. Because I've translated and tested a lot of other extensions, I know that there are several methods to made the various windows automatically resize to the content of it.

Issue with tips window size is only Alf problem

Appearantly not, because beta6 solved this problem without changing something to my system.

Alf, please try abbreviate these phrases: 'Status van geselecteerde account' and 'Niet op schijf opgeslagen' from passwdmaker.properties file.

There is no way to abbreviate these strings, there are no commonly used abbreviations for the words used. I can (and did) remove the word 'van' only.
And besides that, I don't think abbreviation is the right solution for problems with window size. As I said above, there are several methods to solve this in the extension itself.

Attached Files

•  pw7.jpg   24.42KB   10 downloads

[Germanguy]

WELCOME, GERMANGUY!! WE'RE EAGERLY ANTICIPATING de-DE !!!

Thank you! I am working on it Q/A will take a long time though

[teo]

Now there is still 1 window that doesn't remembers its size: Basic options. See attachment.
If I change the size of the basic window and close and reopen it, size is OK still. But if I switch to Advanced options and back to Basic, the size is reset to its original value.

options.xul file is only 1 for both: basic and advanced options. We used 'hide' and 'collapsed' parameters have 2 windows effect. So when you go to advanced options 'persist' parameter remember new window size - advanced window. I think in this release we not resolve this problem. Mine proposal is abbreviate description which you see on attached screenshot to 2 lines. For Polish translation I change last sentence something like: 'Click here to go to advanced options.

Because I've translated and tested a lot of other extensions, I know that there are several methods to made the various windows automatically resize to the content of it.

Please give us useful for this extension method.

There is no way to abbreviate these strings, there are no commonly used abbreviations for the words used. I can (and did) remove the word 'van' only.

In the 1.7 beta 6 release are new sentences for this place which you translated as:
Status van versleuteling geselecteerde account
Status algemene versleuteling:
I think you can abbreviate this sentences as follows:
Versleuteling geselecteerde account -
Algemene versleuteling -
I'm right or no?

Attached Files

•  pm12.png   11.04KB   3 downloads